Fixed: #750 Source synching gives an error on expired surveys in a ne…

…wly attached source Updated version number to p10
GemsTracker · Dec 15, 2022 · 46e1f75 · 46e1f75
1 parent 18d1272
commit 46e1f75
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,9 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 
+## [1.9.1p10]
+- Source synching gives an error on expired surveys in a newly attached source (#750)
+
 ## [1.9.1p9]
 ### Fixed
 - Activity search snippet shows result when non should be there (#736)

diff --git a/classes/Gems/Tracker/Source/LimeSurvey1m9Database.php b/classes/Gems/Tracker/Source/LimeSurvey1m9Database.php
@@ -690,6 +690,7 @@ public function checkSurvey($sourceSurveyId, $surveyId, $userId)
                     $messages[] = sprintf($this->_('Imported the \'%s\' survey.'), $surveyor_title);
                 } else {
                     $messages[] = sprintf($this->_('Skipped the \'%s\' survey because it has an expiry date.'), $surveyor_title);
+                    return $messages;
                 }
             }
             $survey->saveSurvey($values, $userId);

diff --git a/classes/Gems/Versions.php b/classes/Gems/Versions.php
@@ -44,7 +44,7 @@ public final function getBuild()
      */
     public final function getGemsVersion()
     {
-        return '1.9.1p8';
+        return '1.9.1p10';
     }
 
     /**