Fixed: #750 Source synching gives an error on expired surveys in a ne…

…wly attached source
GemsTracker · Dec 15, 2022 · 657301e · 657301e
1 parent 3901383
commit 657301e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -53,6 +53,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 - Score in traffic light screen does not show up inline (#720)
 - SelectModel drops sort columns silently (#672)
 - SQL error in getOrganizationsByCode (#665)
+- Source synching gives an error on expired surveys in a newly attached source (#750)
 - Spelling mistakes in Site setup information (#710)
 - Stored password fields empty stored passwords when nothing is entered (#718)
 - Submitting last survey generates fatal error (#707)

diff --git a/classes/Gems/Tracker/Source/LimeSurvey1m9Database.php b/classes/Gems/Tracker/Source/LimeSurvey1m9Database.php
@@ -690,6 +690,7 @@ public function checkSurvey($sourceSurveyId, $surveyId, $userId)
                     $messages[] = sprintf($this->_('Imported the \'%s\' survey.'), $surveyor_title);
                 } else {
                     $messages[] = sprintf($this->_('Skipped the \'%s\' survey because it has an expiry date.'), $surveyor_title);
+                    return $messages;
                 }
             }
             $survey->saveSurvey($values, $userId);