Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lapis2): delete insertions metadata types #805

Merged
merged 1 commit into from
May 27, 2024

Conversation

fengelniederhammer
Copy link
Contributor

@fengelniederhammer fengelniederhammer commented May 21, 2024

In SILO the insertions are now handled separately from metadata.

resolves #804

PR Checklist

Copy link
Contributor

@JonasKellerer JonasKellerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Only some tests seem to fail.

lapis2/README.md Show resolved Hide resolved
lapis2/README.md Outdated Show resolved Hide resolved
In SILO the insertions are now handled separately from metadata.
@fengelniederhammer fengelniederhammer force-pushed the 804-delete-insertions-from-metadata branch from 771e984 to 7b5dc9f Compare May 23, 2024 12:56
@fengelniederhammer fengelniederhammer merged commit dd0ecd1 into main May 27, 2024
11 checks passed
@fengelniederhammer fengelniederhammer deleted the 804-delete-insertions-from-metadata branch May 27, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete insertions from metadata
2 participants