Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded check in load fuels #545

Merged

Conversation

cfe316
Copy link
Collaborator

@cfe316 cfe316 commented Sep 7, 2023

minor cleanup

Copy link
Collaborator

@gmantegna gmantegna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the for loop still needed if it is looping over just one thing?

@cfe316
Copy link
Collaborator Author

cfe316 commented Sep 27, 2023

In case we needed to add a lowercase none as well or something similar.

It also allows me to add a variable name to "None" which calls it out as being a-thing-which-is-not-a-fuel-and-yet-must-be-listed.

Copy link
Collaborator

@gmantegna gmantegna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job !

@cfe316 cfe316 merged commit c6b7901 into GenXProject:develop Oct 3, 2023
2 checks passed
lbonaldo pushed a commit to lbonaldo/GenX that referenced this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants