-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage capres modifications #333
Merged
sambuddhac
merged 3 commits into
GenXProject:Develop
from
wilson-ricks:storage_capres_modifications
Jan 19, 2023
Merged
Storage capres modifications #333
sambuddhac
merged 3 commits into
GenXProject:Develop
from
wilson-ricks:storage_capres_modifications
Jan 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For technologies with New_Build==-1, capacities will no longer be tracked between stages in multi-stage runs. For example, flexible demand will now correctly have different exogenously-set capacities in each stage, rather than a single constant capacity based on the first stage value.
Storage and reservoir hydro can now contribute to the capacity reserve margin both by directly discharging and by holding stored energy in reserve. The user must specify a new settings tag, "CapResPeriodLength", denoting the expected length of the longest period over which the capacity reserve margin constraint is binding. The model will print a message after solving, telling the user whether the chosen CapResPeriodLength was accurate.
It looks like this PR is mixing capacity reserve margin modifications and multi-stage model modifications. This should probably be split into two PRs. |
sambuddhac
approved these changes
Jan 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the code and approved !!!
cfe316
pushed a commit
to cfe316/GenX
that referenced
this pull request
Apr 27, 2023
lbonaldo
pushed a commit
to lbonaldo/GenX
that referenced
this pull request
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storage and reservoir hydro can now contribute to the capacity reserve margin both by directly discharging and by holding stored energy in reserve. The user must specify a new settings tag, "CapResPeriodLength", denoting the expected length of the longest period over which the capacity reserve margin constraint is binding. The model will print a message after solving, telling the user whether the chosen CapResPeriodLength was accurate.