Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage capres modifications #333

Merged

Conversation

wilson-ricks
Copy link
Collaborator

Storage and reservoir hydro can now contribute to the capacity reserve margin both by directly discharging and by holding stored energy in reserve. The user must specify a new settings tag, "CapResPeriodLength", denoting the expected length of the longest period over which the capacity reserve margin constraint is binding. The model will print a message after solving, telling the user whether the chosen CapResPeriodLength was accurate.

For technologies with New_Build==-1, capacities will no longer be tracked between stages in multi-stage runs. For example, flexible demand will now correctly have different exogenously-set capacities in each stage, rather than a single constant capacity based on the first stage value.
Storage and reservoir hydro can now contribute to the capacity reserve margin both by directly discharging and by holding stored energy in reserve. The user must specify a new settings tag, "CapResPeriodLength", denoting the expected length of the longest period over which the capacity reserve margin constraint is binding. The model will print a message after solving, telling the user whether the chosen CapResPeriodLength was accurate.
@cfe316
Copy link
Collaborator

cfe316 commented Jan 18, 2023

It looks like this PR is mixing capacity reserve margin modifications and multi-stage model modifications. This should probably be split into two PRs.

Copy link
Collaborator

@sambuddhac sambuddhac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the code and approved !!!

@sambuddhac sambuddhac merged commit 06a9fbb into GenXProject:Develop Jan 19, 2023
sambuddhac added a commit that referenced this pull request Jan 27, 2023
sambuddhac added a commit that referenced this pull request Jan 27, 2023
sambuddhac added a commit that referenced this pull request Feb 10, 2023
cfe316 pushed a commit to cfe316/GenX that referenced this pull request Apr 27, 2023
cfe316 pushed a commit that referenced this pull request Apr 27, 2023
lbonaldo pushed a commit to lbonaldo/GenX that referenced this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants