Read jot presenter vc

[RezaAkhtar]

Default jot ids are usually random integers, but we should add a utility function that gets the "next" id or something like that because it will eventually conflict.

[AWiryaman]

Overall just comments needed for functions if they're not in a protocol which is commented

[AWiryaman]

comments

[chuchi-chaschtli]

The main comment that isn't nitpicky stuff is addressing what the text var in the ReadJotPresenter is really doing, and why we need to conform to the UITextViewDelegate in the ReadJotVC. I might jus tbe missing something though

[chuchi-chaschtli]

I think all this logic can be condensed to a smaller function

[AWiryaman]

If you're interested I did it in my branch:
` static func read(givenID: Int) throws -> Jot {
guard let conn = DatabaseManager.shared.conn
else {
throw DatabaseError.selectFailed
}
do {
for row in try conn.prepare("SELECT * FROM jot WHERE id = (givenID)") {
return try parseRow(row: row)
}
}
catch {
throw DatabaseError.selectFailed
}
throw DatabaseError.selectFailed
}

/// Parses a single row from the database into a Jot
///
/// - Parameter row: a row from the database
/// - Returns: a Jot
/// - Throws: DatabaseError.selectFailed if the database SELECT failed
static func parseRow(row: Statement.Element) throws -> Jot {
    guard let optionalID: Int64 = row[0] as? Int64,
        let newData = row[1] as? String
        else {
            throw DatabaseError.selectFailed
    }
    let id = Int(optionalID)
    let row2 = row[2]
    var newQueue = false
    switch row2 {
    case let row2 as Int64:
        if row2 == 1 {
            newQueue = true
        }
    default:
        break
    }
    var newCreatedAt = ""
    let row3 = row[3]
    switch row3 {
    case let row3 as String:
        newCreatedAt = String(row3)
    default:
        throw DatabaseError.selectFailed
    }
    guard let newModifiedAt = row[4] as? String? else{
        throw DatabaseError.selectFailed
    }
    var newLat: Double?
    let row5 = row[5]
    switch row5 {
    case let row5 as Double:
        newLat = Double(row5)
    default:
        throw DatabaseError.selectFailed
    }
    var newLong: Double?
    let row6 = row[6]
    switch row6 {
    case let row6 as Double:
        newLong = Double(row6)
    default:
        throw DatabaseError.selectFailed
    }
    return Jot(id: id,
               data: newData,
               queue: newQueue,
               createdAt: newCreatedAt,
               modifiedAt: newModifiedAt,
               latitude: newLat,
               longitude: newLong)
}`

We can probably just leave it like this and I'll just do the refactor in my branch

[chuchi-chaschtli]

sgtm

[chuchi-chaschtli]

Put the else on this same line as the guard unless the first line is 150+ chars

[chuchi-chaschtli]

Will this ever even get called?? When will the text view change in the ReadJotVC? I might just be missing something here

If it's not getting called, please:

• remove the UITextViewDelegate logic
• remove the var text: String from the Presenter and just make setText(jotID: Int) to something like getText(from jotId: Int) -> String which returns the text for the viewcontroller to display

[RezaAkhtar]

Good call, it wasn't getting called. That was just there when I was trying to mimic what you had to see why mine wasn't working. It's deleted now.

[chuchi-chaschtli]

sgtm