Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle dust scenario in claimer target price #34

Merged

Conversation

trmid
Copy link
Member

@trmid trmid commented Jul 11, 2024

This PR adds an additional fix to the logic change in #33. Please refer to #33 for the full issue context.

The claim fees now ramp up to the tier-specific maxFee instead of the previous highFee over the timeToReachMaxFee period. The highFee was based on the n-3 prize size, which is not guaranteed to have significant value every draw. This change ensures that the maxFee will be reached for every tier sometime in the auction time period, even if the higher tiers have insignificant value.

Copy link

linear bot commented Jul 11, 2024

Copy link

LCOV of commit 21a9ed6 during Tests with 100% Coverage #160

Summary coverage rate:
  lines......: 100.0% (89 of 89 lines)
  functions..: 100.0% (16 of 16 functions)
  branches...: no data found

Files changed coverage rate:
                                  |Lines       |Functions  |Branches    
  Filename                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================
  src/Claimer.sol                 | 100%     58| 100%    10|    -      0

@trmid trmid merged commit 20f52a6 into fix-review Jul 12, 2024
2 checks passed
@trmid trmid deleted the gen-1834-handle-dust-scenario-in-claimer-target-price branch July 12, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant