Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set to NaN if input datetime strings are not in ISO datetime format #3415

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

seisman
Copy link
Member

@seisman seisman commented Jun 1, 2020

Description of proposed changes

Set the value to NaN and raise an warning if the input string can't be parsed as ISO datetime format.

Fixes #3414

Reminders

  • Correct base branch selected? master for new features, 6.1 for bug fixes
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@seisman seisman merged commit 362acc1 into master Jun 1, 2020
@seisman seisman deleted the putvector-nat branch June 1, 2020 05:58
@weiji14
Copy link
Member

weiji14 commented Jun 1, 2020

Cool, thanks guys! I'll go and test it out after dinner, while recompiling gmt master from scratch 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better way to handle NaT (not-a-time)
3 participants