Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add categorical colorbars for plot, plot3d and line colors gallery examples #1267

Merged
merged 11 commits into from
May 13, 2021

Conversation

michaelgrund
Copy link
Member

@michaelgrund michaelgrund commented May 10, 2021

Description of proposed changes

As discussed in #1259 this PR fixes issues appearing during cpt creation and adds categorical colorbars to the examples.

Previews:

Closes #1259.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

As discussed in #1259 this PR fixes issues appearing during cpt creation and adds categorical colorbars to the examples.
@michaelgrund michaelgrund added documentation Improvements or additions to documentation enhancement Improving an existing feature labels May 10, 2021
@michaelgrund michaelgrund marked this pull request as draft May 10, 2021 11:08
@michaelgrund michaelgrund added this to the 0.4.0 milestone May 10, 2021
@michaelgrund michaelgrund marked this pull request as ready for review May 10, 2021 15:52
@michaelgrund michaelgrund linked an issue May 10, 2021 that may be closed by this pull request
@michaelgrund michaelgrund changed the title WIP: Add categorical colorbars for plot and plot3d gallery examples WIP: Add categorical colorbars for plot, plot3d and line colors gallery examples May 10, 2021
@michaelgrund michaelgrund changed the title WIP: Add categorical colorbars for plot, plot3d and line colors gallery examples Add categorical colorbars for plot, plot3d and line colors gallery examples May 11, 2021
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed enhancement Improving an existing feature labels May 12, 2021
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this, just two small suggestions 😄

examples/gallery/3d_plots/scatter3d.py Outdated Show resolved Hide resolved
examples/gallery/3d_plots/scatter3d.py Outdated Show resolved Hide resolved
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label May 13, 2021
@seisman seisman merged commit d32fff5 into master May 13, 2021
@seisman seisman deleted the cat-update-plot-plot3d branch May 13, 2021 13:37
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
…amples (GenericMappingTools#1267)

Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Co-authored-by: Will Schlitzer <schlitzer90@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add categorical colorbars for plot and plot3d gallery examples
4 participants