Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap ternary #1431
Wrap ternary #1431
Changes from 13 commits
b0d2901
601b89a
1333d6a
0ff0b8c
539961c
2982a39
6d454d8
28b16a9
0130355
59bd4fc
2ad07f2
fff77f1
5324d26
331a89a
33d4cb0
c750705
0ea1ea9
ce6de7c
1fa13c7
a3b9af2
9266be1
f776087
2385135
a383101
2999f5b
b5087ec
845fbbd
509384b
395efb0
f7f37da
9b364a8
cfd7ae7
33b200e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
G
is aliased tofill
, but the docstring here sayscolor
. Xref #1617There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried using
G=["fill", "color"]
but it didn't pass the tesing/documentation build. Am I missing a step?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need the rewrite the
use_alias
decorator to support the multi-alias mechanism likeG=["fill", "color"]
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that falls outside of the scope of this pull request. I'll convert this to draft for the time being.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can ignore it now and address the issue in #1617 instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to expand the docstring of
style
, so that users understand whatstyle="c0.2c"
means.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a standard as to what should be used?
pygmt.plot
has the same docstring forstyle
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think rather than adding a lot of text, we could add a link to the symbols and markers gallery page similar to what is done for the region, frame, and projection docstring sections.