Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment about country code in projection examples #290

Merged
merged 2 commits into from
Mar 5, 2019
Merged

Conversation

leouieda
Copy link
Member

@leouieda leouieda commented Mar 5, 2019

Description of proposed changes

Some projection examples use the ISO country codes for the region without any comment about it. Add those comments to avoid confusion.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

@leouieda leouieda merged commit 4079ccb into master Mar 5, 2019
@leouieda leouieda deleted the country-codes branch March 5, 2019 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant