-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark unit tests with @pytest.mark.benchmark part 2 #2924
Changes from 20 commits
622dbcf
5f419f1
f77db73
7d86e3c
2875bf6
998654b
bae569b
cf9f56a
84443ff
7197e8e
7e59b55
a05d975
658c737
b403808
b32d1dc
406fc14
c88f70e
7c14093
af98e47
b7e4e0e
f85aae7
d44092e
eef9dc8
4c1f1e9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -180,6 +180,7 @@ def test_load_notre_dame_topography(): | |
assert data["z"].max() == 960 | ||
|
||
|
||
@pytest.mark.benchmark | ||
def test_earth_relief_holes(): | ||
""" | ||
Check that the @earth_relief_20m_holes.grd dataset loads without errors. | ||
Comment on lines
+183
to
186
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Only benchmarking |
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -56,6 +56,7 @@ def test_figure_region_country_codes(): | |
npt.assert_allclose(fig.region, np.array([0.0, 360.0, -90.0, 90.0])) | ||
|
||
|
||
@pytest.mark.benchmark | ||
def test_figure_repr(): | ||
""" | ||
Make sure that figure output's PNG and HTML printable representations look | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Was a little unsure which test to benchmark for |
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of benchmarking all the various
load_earth_*
functions, I just made created a new one that tests the_load_remote_dataset
function, and it should cover the refactoring happening at #2917. Note that this test is somewhat duplicatingtest_earth_age_01d_with_region
, but should be ok I hope.