Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fatiando continuous integration scripts from 1.1.1 to 1.2.0 #355

Merged
merged 2 commits into from
Oct 31, 2019

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Oct 31, 2019

Description of proposed changes

Fixes randomly failing Mac builds. See release notes at https://github.com/fatiando/continuous-integration/releases/tag/1.2.0.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

@weiji14 weiji14 requested a review from a team October 31, 2019 09:50
@weiji14
Copy link
Member Author

weiji14 commented Oct 31, 2019

@leouieda, sudo chown doesn't work... Crossref fatiando/continuous-integration#19.

@weiji14 weiji14 changed the title Update fatiando continuous integration scripts from 1.1.1 to 1.2.0 WIP Update fatiando continuous integration scripts from 1.1.1 to 1.2.0 Oct 31, 2019
Copy link
Member

@leouieda leouieda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weiji14 sorry, that PR wasn't very clear. Upgrading the scripts isn't enough. You have to add this block to all Azure Mac build configurations: https://github.com/fatiando/continuous-integration/pull/19/files#diff-79a889188c51195ad1884f90e264f03cR43

@weiji14
Copy link
Member Author

weiji14 commented Oct 31, 2019

Ah yes that makes sense, I saw that code block but thought it runs inside the CI script. Things should work now 🤞

@weiji14 weiji14 changed the title WIP Update fatiando continuous integration scripts from 1.1.1 to 1.2.0 Update fatiando continuous integration scripts from 1.1.1 to 1.2.0 Oct 31, 2019
@weiji14 weiji14 requested a review from leouieda October 31, 2019 10:41
@leouieda leouieda merged commit b8bbcfd into GenericMappingTools:master Oct 31, 2019
@leouieda
Copy link
Member

@weiji14 on a separate note, feel free to create branches on the main repository for your pull requests (instead of using your fork). It makes it easier to keep the master branch updated. You've earned it 👍

@weiji14
Copy link
Member Author

weiji14 commented Oct 31, 2019

I'd love to but can't... As mentioned in #317, there's something about GMT organization's permissions that's stopping me from pushing or creating branches directly here.

@weiji14 weiji14 deleted the fatiando-1.2.0 branch October 31, 2019 21:06
@leouieda
Copy link
Member

leouieda commented Nov 1, 2019

@weiji14 could you try again? That's not right and we should get this sorted.

@weiji14
Copy link
Member Author

weiji14 commented Nov 1, 2019

Nope, still not working 😢 I reckon it's my two factor authentication that's the problem, am I the only one in GMT using it? Look at https://help.github.com/en/github/setting-up-and-managing-organizations-and-teams/viewing-whether-users-in-your-organization-have-2fa-enabled

@leouieda
Copy link
Member

leouieda commented Nov 4, 2019

It shouldn't be because I've had that on for years now.

@leouieda
Copy link
Member

leouieda commented Nov 4, 2019

I just tripple checked and you're part of the python team which has admin rights to this repository. So you should be able to push (not to the master branch, though). What sort of error are you getting?

@weiji14
Copy link
Member Author

weiji14 commented Nov 6, 2019

Ok, not sure what happened, but I can push to and create branches on GenericMappingTools repos properly now, including branches on the FOSS4G 2019 Oceania repo! And that's via SSH as well. Did you change something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants