Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check compatibility with Python 3.8 #398

Merged
merged 2 commits into from
Mar 24, 2020
Merged

Check compatibility with Python 3.8 #398

merged 2 commits into from
Mar 24, 2020

Conversation

seisman
Copy link
Member

@seisman seisman commented Mar 18, 2020

Description of proposed changes

Test PyGMT with Python 3.8

Fixes #340.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, it looks like Python 3.8 works! Probably should document somewhere in the README that we support Python 3.6 to 3.8? Just saw that the PyPI badge lists the versions we support, all good.

@seisman seisman merged commit dc178ed into master Mar 24, 2020
@seisman seisman deleted the py3.8 branch March 24, 2020 14:01
@weiji14 weiji14 mentioned this pull request Nov 13, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check Python 3.8 compatibility
2 participants