Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up travis.yml file #404

Merged
merged 4 commits into from
Apr 1, 2020
Merged

Tidy up travis.yml file #404

merged 4 commits into from
Apr 1, 2020

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Mar 26, 2020

Description of proposed changes

Just tidying up the .travis.yml to remove some keys that will be deprecated in dpl v2, see https://blog.travis-ci.com/2019-10-24-build-config-validation. Developers can validate the .travis.yml file using https://config.travis-ci.com/explore.

Fixes #403

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Just tidying up the .travis.yml to remove some stuff that will be deprecated in [dpl](https://github.com/travis-ci/dpl) v2, see https://blog.travis-ci.com/2019-10-24-build-config-validation. Changes include: no need to disable sudo anymore, 'matrix' key renamed to 'jobs', and no need to 'skip_cleanup' anymore (new default is to not cleanup).
@weiji14 weiji14 self-assigned this Mar 26, 2020
@weiji14 weiji14 marked this pull request as ready for review March 26, 2020 02:53
@weiji14 weiji14 mentioned this pull request Mar 26, 2020
5 tasks
.travis.yml Show resolved Hide resolved
@leouieda leouieda merged commit 392c910 into master Apr 1, 2020
@leouieda leouieda deleted the travis_tidyup branch April 1, 2020 15:34
weiji14 added a commit that referenced this pull request Apr 9, 2020
Revert #404 as the `cleanup` tag isn't actually supported yet according to fatiando/verde#250. Also explicitly specifying the build to be on Linux - Ubuntu Bionic 18.04.
weiji14 added a commit that referenced this pull request Apr 9, 2020
Revert some aspects of #404 as the `cleanup` tag isn't actually supported yet according to fatiando/verde#250. Also explicitly specifying the build to be on Linux - Ubuntu Bionic 18.04.
weiji14 added a commit that referenced this pull request Apr 10, 2020
Revert some aspects of #404 as the `cleanup` tag isn't actually supported yet according to fatiando/verde#250. Also explicitly specifying the build to be on Linux - Ubuntu Bionic 18.04.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Travis CI from Services to Github Apps
2 participants