Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Github Pages deployment from Travis #410

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Apr 9, 2020

Description of proposed changes

Revert some aspects of #404 as the cleanup tag isn't actually supported yet according to fatiando/verde#250. Also explicitly specifying the build to be on Linux - Ubuntu Bionic 18.04.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Revert some aspects of #404 as the `cleanup` tag isn't actually supported yet according to fatiando/verde#250. Also explicitly specifying the build to be on Linux - Ubuntu Bionic 18.04.
@weiji14 weiji14 added the maintenance Boring but important stuff for the core devs label Apr 9, 2020
@weiji14 weiji14 requested a review from a team April 9, 2020 23:31
@weiji14 weiji14 merged commit 6b8d159 into master Apr 10, 2020
@weiji14 weiji14 deleted the travis_deploy_fix branch April 10, 2020 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants