Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate unnecessary jobs from Travis CI #567

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Eliminate unnecessary jobs from Travis CI #567

merged 1 commit into from
Aug 19, 2020

Conversation

seisman
Copy link
Member

@seisman seisman commented Aug 19, 2020

We already have full tests (Python 3.6-3.8 on Linux, macOS and Windows)
running on GitHub Actions. No need to waste CI resources on Travis.

Address #566.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

We already have full tests (Python 3.6-3.8 on Linux, macOS and Windows)
running on GitHub Actions. No need to waste CI resources on Travis.
@seisman seisman requested a review from weiji14 August 19, 2020 00:27
@weiji14 weiji14 changed the title Elimiate unnecessary jobs from Travis CI Eliminate unnecessary jobs from Travis CI Aug 19, 2020
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I've also disabled the 'continuous-integration/travis-ci' required check since it won't be needed anymore.

@seisman seisman merged commit a95dd6f into master Aug 19, 2020
@seisman seisman deleted the travis-matrix branch August 19, 2020 01:35
@seisman seisman added the maintenance Boring but important stuff for the core devs label Aug 19, 2020
@seisman seisman added this to the 0.2.x milestone Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants