Open figures using the associated application on Windows #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR improves the `launch_external_viewer` function to open images using the associated application (just like double-click the images) on Windows. The implemention is done by calling the [`os.startfile`](https://docs.python.org/3/library/os.html#os.startfile) function. `os.startfile` is only available on Windows, so need to disable the pylint error `no-member`. The code was originall written in #269 by @leouieda, re-used in #529.
weiji14
approved these changes
Feb 22, 2021
There was a problem hiding this comment.
Probably should get a Windows user to test this (or login to Windows myself), but I think os.startfile should work.
weiji14
changed the title
|
Do we have any Windows developers who can try it? @GenericMappingTools/python @GenericMappingTools/python-maintainers Just to make it clear, when Windows users run the following codes in a Python (or IPython) console: import pygmt
fig = pygmt.Figure()
fig.basemap(projection="X10c", region=[0, 10, 0, 10], frame=True)
fig.show(method="external")the old behavior (using the master branch) is opening the figure in a web browser, the new behavior (using this branch) is opening the figure using the default image viewer. |
9 tasks
seisman
added
bug
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…ingTools#952) This PR improves the `launch_external_viewer` function to open images using the associated application (just like double-click the images) on Windows. The implemention is done by calling the [`os.startfile`](https://docs.python.org/3/library/os.html#os.startfile) function. `os.startfile` is only available on Windows, so need to disable the pylint error `no-member`. The code was originall written in GenericMappingTools#269 by @leouieda, re-used in GenericMappingTools#529.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR improves the
launch_external_viewerfunction to open imagesusing the associated application (just like double-click the images) on
Windows.
The implementation is done by calling the
os.startfilefunction.os.startfileis only available on Windows, so need to disable the pylinterror
no-member.The code was originally written in #528 by @leouieda, re-used in #529,
but I'd like to open this PR separately so that changes in #529 can be
smaller.
BTW, the function is not tested at all because we can't open GUI programs
in CI machines.
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version