[ISSUE apache#3797] Improve DefaultMQProducerImpl code (apache#3809)

* improve DefaultMQProducerImpl code * revert change Co-authored-by: Kvicii <Karonazaba@gmail.com>
GenerousMan · Feb 8, 2022 · e060f45 · e060f45
1 parent be7ee5a
commit e060f45
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java b/client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
@@ -283,9 +283,7 @@ public boolean isPublishTopicNeedUpdate(String topic) {
     }
 
     /**
-     * This method will be removed in the version 5.0.0 and <code>getCheckListener</code> is recommended.
-     *
-     * @return
+     * @deprecated This method will be removed in the version 5.0.0 and {@link DefaultMQProducerImpl#getCheckListener} is recommended.
      */
     @Override
     @Deprecated
@@ -485,6 +483,7 @@ public void send(Message msg,
     }
 
     /**
+     * @deprecated
      * It will be removed at 4.4.0 cause for exception handling and the wrong Semantics of timeout. A new one will be
      * provided in next version
      *
@@ -1035,6 +1034,7 @@ public void send(Message msg, MessageQueue mq, SendCallback sendCallback)
     }
 
     /**
+     * @deprecated
      * It will be removed at 4.4.0 cause for exception handling and the wrong Semantics of timeout. A new one will be
      * provided in next version
      *
@@ -1193,7 +1193,7 @@ public void run() {
                                 sendSelectImpl(msg, selector, arg, CommunicationMode.ASYNC, sendCallback,
                                     timeout - costTime);
                             } catch (MQBrokerException e) {
-                                throw new MQClientException("unknownn exception", e);
+                                throw new MQClientException("unknown exception", e);
                             }
                         } catch (Exception e) {
                             sendCallback.onException(e);
@@ -1205,7 +1205,7 @@ public void run() {
 
             });
         } catch (RejectedExecutionException e) {
-            throw new MQClientException("exector rejected ", e);
+            throw new MQClientException("executor rejected ", e);
         }
     }
 

diff --git a/client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecuter.java b/client/src/main/java/org/apache/rocketmq/client/producer/LocalTransactionExecuter.java
@@ -19,7 +19,7 @@
 import org.apache.rocketmq.common.message.Message;
 
 /**
- * This interface will be removed in the version 5.0.0, interface {@link TransactionListener} is recommended.
+ * @deprecated This interface will be removed in the version 5.0.0, interface {@link TransactionListener} is recommended.
  */
 @Deprecated
 public interface LocalTransactionExecuter {

diff --git a/client/src/main/java/org/apache/rocketmq/client/producer/TransactionCheckListener.java b/client/src/main/java/org/apache/rocketmq/client/producer/TransactionCheckListener.java
@@ -17,8 +17,9 @@
 package org.apache.rocketmq.client.producer;
 
 import org.apache.rocketmq.common.message.MessageExt;
+
 /**
- * This interface will be removed in the version 5.0.0, interface {@link TransactionListener} is recommended.
+ * @deprecated This interface will be removed in the version 5.0.0, interface {@link TransactionListener} is recommended.
  */
 @Deprecated
 public interface TransactionCheckListener {