[ISSUE #3797] Improve DefaultMQProducerImpl code #3809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3809 +/- ##
=============================================
+ Coverage 47.20% 47.22% +0.02%
- Complexity 4889 4893 +4
=============================================
Files 636 636
Lines 42468 42468
Branches 5553 5553
=============================================
+ Hits 20045 20055 +10
+ Misses 19923 19917 -6
+ Partials 2500 2496 -4
Continue to review full report at Codecov.
|
duhenglucky
reviewed
Feb 1, 2022
client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
Outdated
Show resolved
Hide resolved
|
@Kvicii Thanks for your contribution, but it would be better if you can create an issue first just like other PR's did. |
|
@duhenglucky I create an issue, it corresponds to the branch name |
RongtongJin
changed the title
duhenglucky
approved these changes
Feb 8, 2022
devfat
pushed a commit
to devfat/rocketmq
that referenced
this pull request
Mar 3, 2022
* improve DefaultMQProducerImpl code * revert change Co-authored-by: Kvicii <Karonazaba@gmail.com>
GenerousMan
pushed a commit
to GenerousMan/rocketmq
that referenced
this pull request
Aug 12, 2022
* improve DefaultMQProducerImpl code * revert change Co-authored-by: Kvicii <Karonazaba@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure set the target branch to
developWhat is the purpose of the change
Guaranteed readable code style.