Create rate limiter middleware #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefandarius
approved these changes
Apr 19, 2024
| @@ -238,6 +238,10 @@ if (!genezioClass) { | |||
| }); | |||
| }); | |||
|
|
|||
| if(body.params && body.params.length > 0 && body.params[0].isGnzContext === true ) { | |||
There was a problem hiding this comment.
We have a handler for runtime also. Should we put this also there?
There was a problem hiding this comment.
im not sure how the event coming from runtime looks like and i don't know if it's gonna change in the future so i don't know if we should put it just yet
vladiulianbogdan
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Type of change
Description
I added a check on the Lambda handler generator that populates a GenezioContext object with the requestContext and the headrs of the incoming request from AWS. I also added a check in the Ts/Js SdkGenerator to add a new property to a GnzContext object named
isGnzContext. this property is added only if the first parameter of a function is a GnzContext. It helps the lambdaHandler to know whether to populate that parameter or not.Checklist