Exclude spark from core jar #281
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #281 +/- ##
=============================================
+ Coverage 78.38% 78.43% +0.05%
Complexity 1 1
=============================================
Files 141 141
Lines 22480 22480
Branches 408 408
=============================================
+ Hits 17620 17633 +13
+ Misses 4639 4626 -13
Partials 221 221
... and 8 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Currently it doesn't include the changes in mvnrepository artifact upload, we haven't talked that yet which was next step, that's why it is currently draft. |
add output for build
|
Added check for gatk in release test by checking skip-gatk-it in tag message. If skip-gatk-it present in tag message, It will skip gatk part, if not it will try to run gatk part. I saw that gatk uses java 17 as default in the test, until java 17 merges on our end, we should skip gatk part always by adding skip-gatk-it to the tag message. If not it will fail right away because it is asking for java 17. |
| if [[ ${VERSION_NUMBER} != *SNAPSHOT ]]; then | ||
| mvn nexus-staging:rc-list -DnexusUrl=https://oss.sonatype.org/ -DserverId=ossrh -f genomicsdb-${VERSION_NUMBER}.pom | ||
| stagingRepoId=$(mvn nexus-staging:rc-list -DnexusUrl=https://oss.sonatype.org/ -DserverId=ossrh | grep orggenomicsdb|cut -f2 -d' ') | ||
| echo $stagingRepoId | ||
| mvn nexus-staging:rc-close -DserverId=ossrh -DnexusUrl=https://oss.sonatype.org/ -DstagingRepositoryId=$stagingRepoId -f genomicsdb-${VERSION_NUMBER}.pom | ||
| mvn nexus-staging:rc-close -DserverId=ossrh -DnexusUrl=https://oss.sonatype.org/ -DstagingRepositoryId=$stagingRepoId -f genomicsdb-${VERSION_NUMBER}.pom |
There was a problem hiding this comment.
I think this needs to be genomicsdb-spark-${VERSION_NUMBER}.pom based on what I see in the staging repository.
There was a problem hiding this comment.
Ah yes, that's correct. Missed that one somehow. Gonna fix it.
| @@ -62,10 +70,11 @@ jobs: | |||
| dylib_artifact: libtiledbgenomicsdb.dylib.${{ github.ref_name }} | |||
|
|
|||
| test: | |||
| needs: [release-jar] | |||
| needs: [build-and-push-mac-dylib, release-jar] | |||
There was a problem hiding this comment.
I have not understood how this TAG_MESSAGE is being used. Shouldn't release-jar already be dependent on build-and-push-mac-dylib? Do we have to explicitly call out the dependency here?
There was a problem hiding this comment.
Tag message is used for skipping or not skipping the gatk tests which @mlathara asked me to add. Dependency explicitly added so we can use output from that step to pass tag message to test step.
Excludes spark files by executing maven-jar plugin once more to create a jar without spark. After maven-shade creates uber jar, replacing the excluded one with regular jar.