Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new tiledb_array_evaluate_cell to apply filter expressions for the SingleCellTileDBIterator #285

Merged
merged 4 commits into from May 10, 2023

Conversation

nalinigans
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #285 (4cdab7b) into develop (4391c51) will decrease coverage by 1.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #285      +/-   ##
===========================================
- Coverage    78.45%   77.46%   -1.00%     
===========================================
  Files          141      140       -1     
  Lines        22478    22346     -132     
  Branches       406      406              
===========================================
- Hits         17635    17310     -325     
- Misses        4629     4822     +193     
  Partials       214      214              
Impacted Files Coverage Δ
...main/cpp/include/genomicsdb/genomicsdb_iterators.h 97.22% <100.00%> (-0.51%) ⬇️
src/main/cpp/include/genomicsdb/variant_cell.h 100.00% <100.00%> (ø)
...in/cpp/src/genomicsdb/genomicsdb_columnar_field.cc 79.15% <100.00%> (+0.07%) ⬆️
...rc/main/cpp/src/genomicsdb/genomicsdb_iterators.cc 93.03% <100.00%> (+0.09%) ⬆️
src/main/cpp/src/genomicsdb/query_variants.cc 91.96% <100.00%> (-1.41%) ⬇️

... and 36 files with indirect coverage changes

@nalinigans nalinigans requested a review from mlathara May 4, 2023 01:04
@nalinigans
Copy link
Member Author

This requires datma-health/TileDB#149 to be approved first.

@nalinigans
Copy link
Member Author

nalinigans commented May 8, 2023

@mlathara, this has been merged to the latest develop versions of both GenomicsDB and TileDB and is ready for review. Thanks.

Copy link
Contributor

@mlathara mlathara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@nalinigans nalinigans merged commit e351d56 into develop May 10, 2023
22 checks passed
@nalinigans nalinigans deleted the ng_expr_05022023 branch May 10, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants