Expose Expressions::evaluate_cell as TileDB api for use in GenomicsDB #149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
tiledb_array_read
api was doing the read and filtering out the cells that did not match the applied expression before returning the results in the buffers. This was not working very well when there were overflowed buffers. We now just expose theExpressions::evaluate_cell
for the client to evaluate on a per cell basis directly instead of relying ontiledb_array_read
to read and evaluate. This seems to be working well with theSingleCellTileDBIterator
in GenomicsDB.Also added custom muparserx operator
&=
for GT type of operations, e.gGT &= "00"
orGT &= "0/0"
or `GT &= "0|0".