Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag n' Drop not working if filename has empty space #288

Closed
eikaramba opened this issue Oct 4, 2018 · 5 comments
Closed

Drag n' Drop not working if filename has empty space #288

eikaramba opened this issue Oct 4, 2018 · 5 comments
Assignees

Comments

@eikaramba
Copy link

I tested to drag and drop a file to the device in version 1.4 - does not work if file has an whitespace in its filename. However works if i remove the whitespace.
Tested on windows 10 x64
grafik

@rom1v
Copy link
Collaborator

rom1v commented Oct 4, 2018

Thank you for the report.

(command-line parsing is WTF on Windows)

ping @npes87184 #226

We workarounded the same problem for APK installation (see end-of-comment #133 (comment)).

We should do the same for adb push.

@rom1v rom1v added the todo label Oct 4, 2018
@rom1v rom1v self-assigned this Oct 4, 2018
rom1v added a commit that referenced this issue Oct 4, 2018
Quote the arguments of "adb push" to support paths which contain spaces
on Windows.

Fixes <#288>.
@rom1v
Copy link
Collaborator

rom1v commented Oct 4, 2018

Fixed on master.

scrcpy.exe (to replace in v1.4 directory)
SHA-256: e02ae03122a92993077332330c908c79d5082cd3d3b88889fe16af971fd4e0f8

@rom1v rom1v closed this as completed Oct 4, 2018
@eikaramba
Copy link
Author

unfortunately the binary file you linked is linking to this issue and not some exe file. much appreciated if you correct it, otherwise i wait for the next release :)

@rom1v
Copy link
Collaborator

rom1v commented Oct 4, 2018

unfortunately the binary file you linked is linking to this issue and not some exe file.

Oops. I fixed the link.

@npes87184
Copy link
Contributor

@rom1v Thank you for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants