i got an error when i run scrcpy v1.5

[puface]

hi all
i update scrcpy v1.5 today .
i can build success by scrcpy server v1.5.jar file but i got an error when i run scrcpy -m 1024
the error :
397 KB/s (19291 bytes in 0.047s)
ERROR: Exception on thread Thread[main,5,main]
java.lang.IllegalArgumentException: Crop must contains 4 values separated by colons: "''"
at com.genymobile.scrcpy.Server.parseCrop(Server.java:91)
at com.genymobile.scrcpy.Server.createOptions(Server.java:72)
at com.genymobile.scrcpy.Server.main(Server.java:108)
at com.android.internal.os.RuntimeInit.nativeFinishInit(Native Method)
at com.android.internal.os.RuntimeInit.main(RuntimeInit.java:249)

[rom1v]

scrcpy --version

[puface]

hi rom1v
i use ubuntu 16.04 . scrcpy v1.4 can work to well in ubuntu 16.04 am64

$ scrcpy --version 
scrcpy 1.5

dependencies:
 - SDL 2.0.4
 - libavcodec 56.60.100
 - libavformat 56.40.101
 - libavutil 54.31.100

[rom1v]

aapt d badging scrcpy-server.jar | head -1

aapt is in your Android SDK directory, in build-tools/VERSION/.

If you installed it (with sudo ninja install):

aapt d badging /usr/local/share/scrcpy/scrcpy-server.jar | head -1

[puface]

~/scrcpy/x/server$ ls
scrcpy-server.jar
puzhi@puzhi-1080ti:~/scrcpy/x/server$ aapt d badging scrcpy-server.jar | head -1
package: name='com.genymobile.scrcpy' versionCode='6' versionName='1.5' platformBuildVersionName=''

[puface]

$ aapt d badging /usr/local/share/scrcpy/scrcpy-server.jar | head -1
package: name='com.genymobile.scrcpy' versionCode='6' versionName='1.5' platformBuildVersionName=''
the error is :platformBuildVersionName is null ? 

[rom1v]

OK, so it seems good.

From ~/scrcpy/, execute ./run x -m 1024.

[puface]

hi rom1v
i got an same error .
maybe i don't use 28.0.3 version bcz my android version only working at andorid v6 ?
~/Android/Sdk/build-tools$ ls
28.0.3

[rom1v]

java.lang.IllegalArgumentException: Crop must contains 4 values separated by colons: "''"

This is clearly due to a change in the way the crop parameters are passed (to pass an additional parameter) in 345f885. But I don't understand why it does not work as expected on your device.

What is the result of:

adb shell printf '[%s]\\n' a "''" b

?

[puface]

~/scrcpy$ adb shell printf '[%s]\\n' a "''" b
/system/bin/sh: printf: not found 

my android is rk3288 , it's working at android v6.0

[rom1v]

OK, then:

adb shell echo a "''" b

How many spaces does it print between a and b?

[puface]

$ adb shell echo a "''" b
a '' b

[rom1v]

@puface Thank you for the details.

Please checkout the dev branch, it should be fixed 😉

[ghost]

Hi rom1v,
I run into the same problem, but I checked out the dev branch. The git log says that this issue should have been solved.
I'm on Ubuntu 16.04 with a Android 8.0.0 device.
Thanks.

[rom1v]

@mgienal Did you recompile the server? (you must not use the prebuilt server, since the fix updates it)

[ghost]

I see, I'm using the prebuilt server now. So do I need to build my own server to avoid the problem?

[sshock]

I'm also running into this. Can we get an updated prebuilt server 🙏 ?

[rom1v]

@sshock Sorry, didn't have time. But now there is v1.6 😉