Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Command-Line-Option to flip horizontal (Feature Request) #3819

Closed
Wonko52 opened this issue Mar 14, 2023 · 4 comments
Closed

Add Command-Line-Option to flip horizontal (Feature Request) #3819

Wonko52 opened this issue Mar 14, 2023 · 4 comments

Comments

@Wonko52
Copy link

Wonko52 commented Mar 14, 2023

A command line option to mirror the output horizontally would be helpful.

Use case:
I use a tablet with a teleprompter app. The app displays the text mirrored, so that it is displayed correctly in the teleprompter mirror.

With a laptop I control the app via scrcpy (text speed, pause, etc.). The text is displayed mirrored in scrcpy - because it is in the app.

Workaround: I compiled myself a version in which I applied the bugfix described here.
#1380 (comment)

It would be better if I could simply set this via a parameter at startup.

@Wonko52 Wonko52 changed the title Add Command-Line-Option to flip horizontal Add Command-Line-Option to flip horizontal (Feature Request) Mar 14, 2023
@rom1v
Copy link
Collaborator

rom1v commented Mar 14, 2023

I understand that it could be convenient, but I'm quite reticent to add this feature, which is not very useful in general cases (only to workaround few buggy devices, and your specific use case your describe here). Here are some reasons.

There are two rotation level in scrcpy (if it ignore the device rotation itself): https://github.com/Genymobile/scrcpy/blob/master/doc/video.md#rotation

  • --lock-video-orientation
  • --rotation

Both support the 4 possible rotations. However, flip is not possible on the capture side, so it would only be possible for the dynamic orientation.

This parameter (--rotation) can also be changed at runtime, so with an additional flip, it would be less intuitive/consistent.

And it would also complexity (i.e. bugs) in the display/screen code (which is already not very pretty).

For specific use cases like yours, a simple patch solves the problem specifically, so IMO it is not worth it.

@KnIfER
Copy link

KnIfER commented Jun 9, 2023

or consider a local service for web browser , so that others can do anyting to the video output (using css) ?

rom1v added a commit that referenced this issue Nov 20, 2023
Deprecate the option --rotation and introduce a new option
--display-orientation with the 8 possible orientations (0, 90, 180, 270,
flip0, flip90, flip180 and flip270).

New shortcuts MOD+Shift+(arrow) dynamically change the display
(horizontal or vertical) flip.

Fixes <#3819>
@rom1v
Copy link
Collaborator

rom1v commented Nov 20, 2023

Please test #4441.

@rom1v rom1v closed this as completed in bb88b60 Nov 25, 2023
@rom1v
Copy link
Collaborator

rom1v commented Nov 25, 2023

Implemented in v2.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants