Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in --no-video mode, scrcpy not terminate when disconnected #4207

Closed
chieonol opened this issue Aug 1, 2023 · 2 comments
Closed

in --no-video mode, scrcpy not terminate when disconnected #4207

chieonol opened this issue Aug 1, 2023 · 2 comments

Comments

@chieonol
Copy link

chieonol commented Aug 1, 2023

  • [v] I have read the FAQ.
  • [v] I have searched in existing issues.

Environment

  • OS: Windows
  • scrcpy version: 2.1.1
  • installation method: release
  • device model: google pixel 2 xl, lg wing (and every devices)
  • Android version: 13

Describe the bug

If scrcpy has video, I can see terminal's process has adb(not showing scrcpy). And it terminates when disconnected so i can start a new one.
But in --no-video , terminal has adb and scrcpy. And only adb terminates when disconnected, scrcpy steel alive and terminal shows it still running, I cannot start new one until I've stop(ctrl+c or kill process in task manager)
I think scrcpy must be terminated too when adb terminated.

[ when ] video video-disconneted no-video no-video-disconneted
processes adb - adb,scrcpy scrcpy
can i use console? no yes no no
@chieonol
Copy link
Author

chieonol commented Aug 1, 2023

I forgot images.
화면 캡처 2023-08-01 174714
화면 캡처 2023-08-01 174818
화면 캡처 2023-08-01 174945
화면 캡처 2023-08-01 175058
화면 캡처 2023-08-01 180008

@rom1v
Copy link
Collaborator

rom1v commented Aug 1, 2023

Thank you for your report.

Fixed by 0983f0a.

@rom1v rom1v closed this as completed Aug 1, 2023
rom1v added a commit that referenced this issue Aug 1, 2023
@rom1v
Report device disconnection on audio EOS
0983f0a 
If --no-video was set, then device disconnection was not reported. To
avoid the problem, report device disconnection also on audio
end-of-stream (EOS).

If both video and audio are enabled, then a device disconnection event
will be sent twice, but only the first one will be handled (since it
makes scrcpy exit).

Fixes #4207 <#4207>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rom1v @chieonol