HIDPI support broken on Macos builds

[lpkruger]

The issue is straightforward - screen.c does not #include "config.h" as it should so it never picks up the proper #ifdef from the Meson config.

It worked in 1.8 perhaps by accident because screen.c includes video_buffer.h which used to include config.h. This was removed in
ebccb9f

with the result that screen.c no longer picks up the Meson preprocessor defines.

[lpkruger]

BTW - grepping for "config.h" shows there are quite a few source files that do not have this include. Since it is difficult to immediately know which file depends on Meson configs and which one does not, perhaps they should all include config.h ?

[lpkruger]

here is a tested fix for the HIDPI issue

Author: Louis Kruger <louisk@gmail.com>
Date:   Sat Sep 28 18:54:08 2019 -0400

    include config.h

diff --git a/app/src/screen.c b/app/src/screen.c
index 18d24dd..e34bcf4 100644
--- a/app/src/screen.c
+++ b/app/src/screen.c
@@ -3,6 +3,7 @@
 #include <string.h>
 #include <SDL2/SDL.h>

+#include "config.h"
 #include "common.h"
 #include "compat.h"
 #include "icon.xpm"

[rom1v]

here is a tested fix for the HIDPI issue

🎉

Do you mean #15?

screen.c does not #include "config.h"

😱

Since it is difficult to immediately know which file depends on Meson configs and which one does not, perhaps they should all include config.h ?

👍

[rom1v]

129dabc 1f8ba1c

[lpkruger]

Sorry I do not know whether this fixed #15 or not. If I get a free minute I could look into that though.