Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increment repeat counter when injecting key events #1519

Closed
wants to merge 3 commits into from
Closed

Increment repeat counter when injecting key events #1519

wants to merge 3 commits into from

Conversation

xeropresence
Copy link
Contributor

Improves #1013

@xeropresence
Handle repeating keycodes
d297747
@xeropresence
Formatting cleanup
11104f9 
Change function order so its consistent throughout the program -> action,keycode,metastate,repeat
@xeropresence
Convert repeat counter to an unsigned int
44ad422
rom1v pushed a commit that referenced this pull request Jun 19, 2020
@xeropresence @rom1v
Handle repeating keycodes
9a7e8da 
Initialize "repeat" count on key events.

PR #1519 <#1519>
Refs #1013 <#1013>

Signed-off-by: Romain Vimont <rom@rom1v.com>
@rom1v
Copy link
Collaborator

rom1v commented Jun 19, 2020 •
edited
Loading

Thank you 👍

I rebased on current dev, squashed your commits, and applied the following changes:

  • move "repeat" global variable to the input manager structure"
  • always reorder repeat before metastate (in method parameters and serialization) for consistency (this is the order used both by KeyEvent on Android and SDL_KeyboardEvent in SDL)
  • fix unit tests

The resulting commit is repeat.

Please review and test :)

PS: the Author in your commits is xeropresence <3128949+xeropresence@users.noreply.github.com>. Do you have a better identity?

@xeropresence
Copy link
Contributor Author

Sorry for the long wait, I've tested the branch and everything seems to be working as expected.

I prefer to remain as private as possible ;)

rom1v pushed a commit that referenced this pull request Jun 27, 2020
@xeropresence @rom1v
Handle repeating keycodes
3c1ed5d 
Initialize "repeat" count on key events.

PR #1519 <#1519>
Refs #1013 <#1013>

Signed-off-by: Romain Vimont <rom@rom1v.com>
@rom1v
Copy link
Collaborator

rom1v commented Jun 27, 2020

Merged into dev: 3c1ed5d

@rom1v rom1v closed this Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xeropresence @rom1v