Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed output to be give clearer instructions #1783

Closed
wants to merge 1 commit into from
Closed

Changed output to be give clearer instructions #1783

wants to merge 1 commit into from

Conversation

grimops
Copy link

@grimops grimops commented Sep 22, 2020

I changed the output to ask the user to press enter instead of any key which does not work.

@npes87184
Copy link
Contributor

Nice catch!

Reviewed-by: Yu-Chen Lin npes87184@gmail.com

@rom1v
Copy link
Collaborator

rom1v commented Oct 1, 2020

Thank you 👍

I rebased on dev, add a capital letter: Enter, and merged: 56d237f

@rom1v rom1v closed this Oct 1, 2020
rom1v pushed a commit that referenced this pull request Oct 1, 2020
@rom1v
Fix "press Enter key" message
56d237f 
The message said "Press any key to continue...", whereas only
Enter/Return is accepted.

PR #1783 <#1783>
Fixes #1757 <#1757>

Reviewed-by: Yu-Chen Lin <npes87184@gmail.com>
Signed-off-by: Romain Vimont <rom@rom1v.com>
This was referenced Oct 1, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npes87184 npes87184 npes87184 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grimops @npes87184 @rom1v