Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new option for falling back to clipboard pasting on character injection failures. #1805

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

starrify
Copy link

@starrify starrify commented Oct 2, 2020

So that non-ASCII characters may be entered via IMEs. Resolves #37.

Submitting the changes here for now for review. Further documentation work would be needed on README.md and FAQ.md either in this PR or as separate ones if this gets merged early.

@rom1v
Copy link
Collaborator

rom1v commented Oct 3, 2020

Hi,

Thank you for the proposal.

Using this method to inject text has drawbacks: #1426 (comment)
But behind a flag, and only as a fallback, it might be acceptable.

@rom1v
Copy link
Collaborator

rom1v commented Oct 5, 2020

@npes87184 Any opinion about this?

@npes87184
Copy link
Contributor

npes87184 commented Oct 6, 2020

I don't like this workaround. From my point of view, instead of adding an option that will be removed eventually, we should find time to actually implement the IME into scrcpy to resolve the problem correctly.

BTW, @rom1v I guess you are doing static build for client now, right?

@rom1v
Copy link
Collaborator

rom1v commented Oct 6, 2020

From my point of view, instead of adding an option that will be removed eventually,

Does it work fine for you when you type chinese? One advantage is that it may work without installing an app.

Do you think that it could be enabled by default when the character may not be injected (so that there is no new option)?

I guess you are doing static build for client now, right?

No, until #1753 is solved, I use the last version of FFmpeg built by zeranoe.

@npes87184
Copy link
Contributor

From my point of view, instead of adding an option that will be removed eventually,

Does it work fine for you when you type chinese? One advantage is that it may work without installing an app.

I will give it a try recently (maybe tonight if possible). Yes, without needing to install an app is a benefit in this method and I haven't noticed this.

Do you think that it could be enabled by default when the character may not be injected (so that there is no new option)?

Because the benefit of not having to install apps, I change my mind, I think it is worth to add this workaround in this time. However, too many options is also a problem now. If possible, I stand for not adding new option for this method.

I guess you are doing static build for client now, right?

No, until #1753 is solved, I use the last version of FFmpeg built by zeranoe.

Ok, I will take a look in my free time for static build. BTW, don't give high expectation, I am really busy recently :P.

@npes87184
Copy link
Contributor

From my point of view, instead of adding an option that will be removed eventually,

Does it work fine for you when you type chinese? One advantage is that it may work without installing an app.

It doesn't work for me. I ran scrcpy with --char-inject-fallback. And I cannot type chinese. Do I need to do something special? Like using some specific IME?

Do you think that it could be enabled by default when the character may not be injected (so that there is no new option)?

I guess you are doing static build for client now, right?

No, until #1753 is solved, I use the last version of FFmpeg built by zeranoe.

@starrify
Copy link
Author

starrify commented Oct 6, 2020

It doesn't work for me.

Hmm I'm sorry to know that. I also used an IME for Chinese for testing, and the environments are:

  • GNU/Linux x86_64 5.8.10-arch1-1
  • Xorg 1.20.9
  • Gnome-shell 3.36.6 / GDM 3.36.3
  • ibus 1.5.22

Could you share some info on your side so I may have a look?

@quyleanh
Copy link
Contributor

Is there any progress for this PR? @rom1v @npes87184

Copy link

@deltachonglee81 deltachonglee81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the system

@rom1v
Copy link
Collaborator

rom1v commented Oct 27, 2021

Please test the new --hid-keyboard on dev branch.

@npes87184 Does IME work perfectly with HID?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants