Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson: Do not use full path with mingw tools name. #2185

Closed
wants to merge 1 commit into from
Closed

meson: Do not use full path with mingw tools name. #2185

wants to merge 1 commit into from

Conversation

Biswa96
Copy link
Contributor

@Biswa96 Biswa96 commented Mar 9, 2021

This helps to use mingw toolchains which are not in /usr/bin path.

This helps to use mingw toolchains which are not in /usr/bin path.
rom1v pushed a commit that referenced this pull request Mar 9, 2021
This helps to use mingw toolchains which are not in /usr/bin path.

PR #2185 <#2185>

Signed-off-by: Romain Vimont <rom@rom1v.com>
@rom1v
Copy link
Collaborator

rom1v commented Mar 9, 2021

Thank you 👍

Merged into dev: d1789f0

@rom1v rom1v closed this Mar 9, 2021
@Biswa96 Biswa96 deleted the meson-cross-win branch March 9, 2021 09:03
@Biswa96
Copy link
Contributor Author

Biswa96 commented Mar 9, 2021

I could also change the upstream branch. BTW, have you consider to use pkg-config or cmake to find cross-compiled sdl and ffmpeg dependencies instead of hardcoded path in app/meson.build? Spoiler: I have cross compiled ffmpeg with a lilliputian shell script.

@rom1v
Copy link
Collaborator

rom1v commented Mar 9, 2021

I could also change the upstream branch.

What do you mean?

BTW, have you consider to use pkg-config […] to find cross-compiled sdl and ffmpeg dependencies instead of hardcoded path in app/meson.build

Oh yes, please. These hardcoded paths in meson are so hacky.

In the end, I would like something like contrib in VLC, where each dependency is in its own folder, and we can make install them to somewhere (a first step could be to just use the prebuilts binary, but make install them to the "prefix" folder), and build scrcpy against them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants