Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create README.jp.md #2195

Closed
wants to merge 5 commits into from
Closed

Create README.jp.md #2195

wants to merge 5 commits into from

Conversation

aruko-210
Copy link
Contributor

I added Japanese translation for REDME.md

@rom1v
Copy link
Collaborator

rom1v commented Mar 14, 2021

Thank you 👍

Could someone understanding japanese review it, please?

@rom1v
Copy link
Collaborator

rom1v commented Mar 16, 2021

I made the following changes (I don't want to reference all languages from all README, but I want to reference them from the main README):

diff --git a/README.jp.md b/README.jp.md
index 22ceee3d..80dc9b7f 100644
--- a/README.jp.md
+++ b/README.jp.md
@@ -793,13 +793,3 @@ _³Android 7以上のみ._
 
 [article-intro]: https://blog.rom1v.com/2018/03/introducing-scrcpy/
 [article-tcpip]: https://www.genymotion.com/blog/open-source-project-scrcpy-now-works-wirelessly/
-
-## 翻訳
-
-このREADMEは他の言語で利用可能です:
-
-- [Indonesian (インドネシア語, `id`) - v1.16](README.id.md)
-- [한국어 (韓国語, `ko`) - v1.11](README.ko.md)
-- [português brasileiro (ブラジルポルトガル語, `pt-BR`) - v1.17](README.pt-br.md)
-- [简体中文 (簡体字中国語, `zh-Hans`) - v1.17](README.zh-Hans.md)
-- [繁體中文 (繁体字中国語, `zh-Hant`) - v1.15](README.zh-Hant.md)
diff --git a/README.md b/README.md
index 759e7920..9376616a 100644
--- a/README.md
+++ b/README.md
@@ -799,6 +799,7 @@ Read the [developers page].
 This README is available in other languages:
 
 - [Indonesian (Indonesia, `id`) - v1.16](README.id.md)
+- [日本語 (Japanese, `jp`) - v1.17)(README.jp.md)
 - [한국어 (Korean, `ko`) - v1.11](README.ko.md)
 - [português brasileiro (Brazilian Portuguese, `pt-BR`) - v1.17](README.pt-br.md)
 - [简体中文 (Simplified Chinese, `zh-Hans`) - v1.17](README.zh-Hans.md)

Please check that "japanese" is correctly translated (by Google translate): 日本語 😉

Your commit author is: aruko-210 <75659920+aruko-210@users.noreply.github.com>. Could you give a real e-mail for the commit author, please?

rom1v pushed a commit that referenced this pull request Mar 16, 2021
PR #2195 <#2195>

Signed-off-by: Romain Vimont <rom@rom1v.com>
rom1v pushed a commit that referenced this pull request Mar 16, 2021
PR #2195 <#2195>

Signed-off-by: Romain Vimont <rom@rom1v.com>
rom1v pushed a commit that referenced this pull request Mar 16, 2021
PR #2195 <#2195>

Signed-off-by: Romain Vimont <rom@rom1v.com>
Copy link
Contributor

@yume-chan yume-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know Japanese well so I only pointed out some obvious mistakes.

README.jp.md Outdated
`adb connect DEVICE_IP:5555` _(`DEVICE_IP`は置き換える)_
6. 通常通り`scrcpy`を実行します。

この方法はビットレートと定義を減らすのにおそらく有用です:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

定義->解像度

README.jp.md Outdated

- **軽量** (ネイティブ、デバイス画面表示のみ)
- **パフォーマンス** (30~60fps)
- **クオリティ** (1920x1018以上)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1080

README.jp.md Outdated

```bash
choco install scrcpy
choco install adb # if you don't have it yet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe should also translate all comments (parts after #) in code snippets.

README.jp.md Outdated

# scrcpy (v1.17)

[他の言語で読む](#translations)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also remove this line


[snap-link]: https://snapstats.org/snaps/scrcpy

[snap]: https://en.wikipedia.org/wiki/Snappy_(package_manager)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace with Japanese Wikipedia link; https://ja.wikipedia.org/wiki/Snappy

README.jp.md Outdated

_scrcpy_ は3つの回転を管理することに注意:
- <kbd>MOD</kbd>+<kbd>r</kbd>はデバイスに縦向きと横向きの切り替えを要求する
(現在実行中のアプリで要求している向きをサポートしている場合、拒否する場合がある)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rom1v The original text is

the current running app may refuse, if it does support the requested orientation

Shouldn't it be "if it doesn't support"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 1fb7957

README.jp.md Outdated
[BUILD]: BUILD.md


## 共通の問題
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よくある質問

README.jp.md Outdated
| 通知パネルを折りたたむ | <kbd>MOD</kbd>+<kbd>Shift</kbd>+<kbd>n</kbd>
| クリップボードへのコピー³ | <kbd>MOD</kbd>+<kbd>c</kbd>
| クリップボードへのカット³ | <kbd>MOD</kbd>+<kbd>x</kbd>
| クリップボードとペーストの同期³ | <kbd>MOD</kbd>+<kbd>v</kbd>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

クリップボードの同期とペースト

README.jp.md Outdated

#### ピンチしてズームする

"ピンチしてズームする"をシミュレートするには: <kbd>Ctrl</kbd>+_click-and-move_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

click-and-move

use uniform wording: click-and-move or クリック&移動

| クリップボードとペーストの同期³ | <kbd>MOD</kbd>+<kbd>v</kbd>
| コンピュータのクリップボードテキストの挿入 | <kbd>MOD</kbd>+<kbd>Shift</kbd>+<kbd>v</kbd>
| FPSカウンタ有効/無効(標準入出力上) | <kbd>MOD</kbd>+<kbd>i</kbd>
| ピンチしてズームする | <kbd>Ctrl</kbd>+_クリック&移動_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

クリック&移動

use uniform wording: click-and-move or クリック&移動

rom1v added a commit that referenced this pull request Mar 17, 2021
@aruko-210 aruko-210 closed this Mar 17, 2021
@aruko-210
Copy link
Contributor Author

I'm sorry. I made a mistake in web operation

@aruko-210 aruko-210 reopened this Mar 17, 2021
@aruko-210
Copy link
Contributor Author

aruko-210 commented Mar 17, 2021

Please check that "japanese" is correctly translated (by Google translate): 日本語 😉

@rom1v
It's okey

@aruko-210
Copy link
Contributor Author

@yume-chan
Thank you for checking.
I modified. so please check my chenges.

README.jp.md Outdated
- **クオリティ** (1920x1080以上)
- **低遅延** ([35~70ms][lowlatency])
- **短い起動時間** (初回画像を1秒以内に表示)
- **非侵入型** (デバイスに何もインストールされない)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It did install something on the device, but it will clean up on exit. Hence the "nothing is left installed".

README.jp.md Outdated

[enable-adb]: https://developer.android.com/studio/command-line/adb.html#Enabling

一部ののAndroidデバイスでは、キーボードとマウスを使用して制御する[追加オプション][control]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An extra の

README.jp.md Outdated
Androidデバイスを低解像度でミラーリングする場合、パフォーマンス向上に便利な
場合があります。

幅と高さをある値に制限するには(例:1024):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- 幅と高さをある値に制限するには(例:1024):
+ 幅と高さをある値(例:1024)に制限するには:

In fact --max-size will limit the larger one of width and height to the given value ("both the width and height"). Need more clarification.

README.jp.md Outdated
# Ctrl+Cで録画を中断する
```

"スキップされたフレーム"はリアルタイムで表示されなくても録画されます
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- "スキップされたフレーム"はリアルタイムで表示されなくても録画されます(パフォーマンス上の理由)。
+ "スキップされたフレーム"はリアルタイムで(パフォーマンス上の理由で)表示されなくても録画されます

README.jp.md Outdated
`adb connect DEVICE_IP:5555` _(`DEVICE_IP`は置き換える)_
6. 通常通り`scrcpy`を実行します。

この方法はビットレートと鮮明度を減らすのにおそらく有用です:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really "resolution", the command below is --max-size

README.jp.md Outdated
便宜上、`POWER`がscrcpyを介して(右クリックもしくは<kbd>MOD</kbd>+<kbd>p</kbd>を
介して)送信される場合、(ベストエフォートベースで)少し遅れて、強制的に画面を
非表示にします。
物理的な`POWER`ボタンを押しても画面は表示されます。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

押しても -> なら?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry. I couldn't get your suggestion

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally, the physical POWER button will turn on the screen, right?

In scrcpy, it will turn off screen after injecting a POWER event. But pressing the physical POWER button still turn the screen on.

So there shouldn't be "ても"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh... Now I understand the detail.
Thank you.

@aruko-210
Copy link
Contributor Author

@yume-chan
Thank you for checking.
I modified.

Copy link
Contributor

@yume-chan yume-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

@aruko-210
Copy link
Contributor Author

Your commit author is: aruko-210 <75659920+aruko-210@users.noreply.github.com>. Could you give a real e-mail for the commit author, please?

@rom1v
I modified commit author.

@aruko-210
Copy link
Contributor Author

I made the following changes (I don't want to reference all languages from all README, but I want to reference them from the main README):

diff --git a/README.jp.md b/README.jp.md
index 22ceee3d..80dc9b7f 100644
--- a/README.jp.md
+++ b/README.jp.md
@@ -793,13 +793,3 @@ _³Android 7以上のみ._
 
 [article-intro]: https://blog.rom1v.com/2018/03/introducing-scrcpy/
 [article-tcpip]: https://www.genymotion.com/blog/open-source-project-scrcpy-now-works-wirelessly/
-
-## 翻訳
-
-このREADMEは他の言語で利用可能です:
-
-- [Indonesian (インドネシア語, `id`) - v1.16](README.id.md)
-- [한국어 (韓国語, `ko`) - v1.11](README.ko.md)
-- [português brasileiro (ブラジルポルトガル語, `pt-BR`) - v1.17](README.pt-br.md)
-- [简体中文 (簡体字中国語, `zh-Hans`) - v1.17](README.zh-Hans.md)
-- [繁體中文 (繁体字中国語, `zh-Hant`) - v1.15](README.zh-Hant.md)
diff --git a/README.md b/README.md
index 759e7920..9376616a 100644
--- a/README.md
+++ b/README.md
@@ -799,6 +799,7 @@ Read the [developers page].
 This README is available in other languages:
 
 - [Indonesian (Indonesia, `id`) - v1.16](README.id.md)
+- [日本語 (Japanese, `jp`) - v1.17)(README.jp.md)
 - [한국어 (Korean, `ko`) - v1.11](README.ko.md)
 - [português brasileiro (Brazilian Portuguese, `pt-BR`) - v1.17](README.pt-br.md)
 - [简体中文 (Simplified Chinese, `zh-Hans`) - v1.17](README.zh-Hans.md)

Please check that "japanese" is correctly translated (by Google translate): 日本語 😉

@rom1v
I modified like this.

@rom1v
Copy link
Collaborator

rom1v commented Mar 27, 2021

Thanks, I will try to review/merge this week-end.

rom1v pushed a commit that referenced this pull request Mar 28, 2021
PR #2195 <#2195>

Signed-off-by: Romain Vimont <rom@rom1v.com>
@rom1v
Copy link
Collaborator

rom1v commented Mar 28, 2021

Merged 6a217b7

@rom1v rom1v closed this Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants