Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the order of operations #2223

Closed
wants to merge 1 commit into from

Conversation

FossPrime
Copy link
Contributor

@FossPrime FossPrime commented Mar 29, 2021

Mistakes I made, admittedly low on sleep:

  • Used root dispite all warnings
  • Ran non-prebuilt code... and couldn't undo.

Clarified by using headings and re-ordering to make prebuilt section stand-alone

Mistakes I made, admittedly low on sleep:
# Used root dispite all warnings
# Ran non-prebuilt code... and couldn't undo.

Clarified by using headings and re-ordering to make prebuilt section stand-alone
rom1v pushed a commit that referenced this pull request Mar 29, 2021
PR #2223 <#2223>

Signed-off-by: Romain Vimont <rom@rom1v.com>
@rom1v
Copy link
Collaborator

rom1v commented Mar 29, 2021

Thank you.

I moved more prebuilt server-related doc and changed minor things, here is the result: fc5de88

Is it ok for you?

Then I wrote a script to simplify installation (on install_release branch):
https://github.com/Genymobile/scrcpy/blob/install_release/BUILD.md#simple

I will merge both on master soon if everything is ok.

@FossPrime
Copy link
Contributor Author

Looks good! I was concerned about breaking the #Prebuilt-server link, but making people read from top to bottom is probably desireable.

@FossPrime FossPrime closed this Mar 29, 2021
@rom1v
Copy link
Collaborator

rom1v commented Mar 29, 2021

I was concerned about breaking the #Prebuilt-server link

Yes, me too, but Github-markdown does not allow to force an anchor name (without breaking other things) 😕

But anyway, with the "simple" method, few people would need to use the prebuilt server explicitly (they'll just use install_release.sh I guess).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants