Add option to prevent power on on start #3210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rom1v
added a commit
that referenced
this pull request
Apr 23, 2022
rom1v
added a commit
that referenced
this pull request
Apr 23, 2022
|
I'm fine with this but wouldn't this be achievable with #3191? |
Probably not, since the behavior is enabled by default, and the option disables it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, on start, the device is powered on. To prevent this behavior, add a new option
--no-power-on.Fixes #3148
Are you ok with the option name (
--no-power-on)?There is already an option
--power-off-on-close, so we could use--no-power-on-on-start, but I think I prefer--no-power-on).