New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed to get displayInfo in Android Q with No flags #3573

Closed

issess wants to merge 1 commit into Genymobile:dev from issess:dev

Contributor

issess commented Nov 9, 2022 •

edited

Loading

Hi, I fixed a bug to get displayInfo in fallback mode on Android Q OS.

https://cs.android.com/android/_/android/platform/frameworks/base/+/1039ea50f3e1944f5d670cfdeadfdb17b3442ed7

after this commit, It was changed dump message from
sb.append(", displayId ");
to
sb.append("", displayId ");

so, I removed \" to support all android version.

please review this bug patch.


          fixed to get displayInfo in Android Q with No flags

86032b6

rom1v pushed a commit that referenced this pull request


          Fix DisplayInfo parsing for Android Q

94ae3f1

The DisplayInfo dump format has slightly changed in AOSP:
<https://android.googlesource.com/platform/frameworks/base.git/+/1039ea50f3e1944f5d670cfdeadfdb17b3442ed7>

PR #3573 <#3573>
Ref #3416 <#3416>

Signed-off-by: Romain Vimont <rom@rom1v.com>

Collaborator

rom1v commented Nov 12, 2022 •

edited

Loading

Thank you, LGTM 👍

Merged into dev: 597703b

rom1v closed this

rom1v pushed a commit that referenced this pull request


          Fix DisplayInfo parsing for Android Q

597703b

The DisplayInfo dump format has slightly changed in AOSP:
<https://android.googlesource.com/platform/frameworks/base.git/+/1039ea50f3e1944f5d670cfdeadfdb17b3442ed7>

PR #3573 <#3573>
Ref #3416 <#3416>

Signed-off-by: Romain Vimont <rom@rom1v.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment