New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notify ScreenEncoder when a folding event occurs #3979
Conversation
@Override | ||
public void onFoldChanged(int displayId) { | ||
// TODO: rename rotationChanged to something like displayChanged? To discuss with @rom1v | ||
rotationChanged.set(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rom1v Here I guess this variable could be renamed? Or do we need two variables?
Awesome, I didn't know there was such a fold change event. I will review in details later (I have other things to implement/fix first). In any case, I will merge it for the next release (2.1). Thank you. |
I rebased on current I pushed to |
Merged: 24999d0 |
Hello 馃憢
It's been a while since my last contribution, it's a pleasure to be able to contribute again to this amazing project!
I'm a lucky owner of a foldable phone ( Z fold 4 ) and I've seen that scrcpy does not handle the fold events ( The SDL Window does not update its size when I bend my phone ).
I just fixed this issue ( it is implemented the same way as RotationWatcher ).
Btw I have a little concern about the naming of the boolean
ScreenEncoder.rotationChanged
which may not have a good name after this PR.