Add --pause-on-exit to simplify launchers #4130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ratijas
reviewed
Jun 29, 2023
rom1v
changed the title
rom1v
added a commit
that referenced
this pull request
Jun 30, 2023
Add an option to make scrcpy pause on exit.
Three behaviors are possible:
- always pause on exit:
--pause-on-exit
--pause-on-exit=true
- never pause on exit:
(no option)
--pause-on-exit=false
- pause when scrcpy returns with an error (a non-zero exit code):
--pause-on-exit=if-error
This is useful to prevent the terminal window from automatically
closing, so that error messages can be read.
Refs #3817 <#3817>
Refs #3822 <#3822>
PR #4130 <#4130>
rom1v
added a commit
that referenced
this pull request
Jun 30, 2023
|
I refactored to support
|
Add an option to make scrcpy pause on exit.
Three behaviors are possible:
- always pause on exit:
--pause-on-exit
--pause-on-exit=true
- never pause on exit:
(no option)
--pause-on-exit=false
- pause when scrcpy returns with an error (a non-zero exit code):
--pause-on-exit=if-error
This is useful to prevent the terminal window from automatically
closing, so that error messages can be read.
Refs #3817 <#3817>
Refs #3822 <#3822>
PR #4130 <#4130>
|
Let's merge it (I thought it was already done). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scrcpy-console.batandscrcpy-console.desktopmust keep the terminal open if scrcpy fails with an error.It was implemented in cmd and shell respectively, which added complexity.
Add an option
--pause-on-exitin scrcpy to simplify.Three behaviors are possible:
--pause-on-exit--pause-on-exit=true--pause-on-exit=false--pause-on-exit=if-errorOne problem to consider is that an error in command line parsing could occur before
--pause-on-errorwas taken into account. For that purpose, if getopt did not detect it, this parameter is searched in the wholeargvarray "manually" (without getopt) so that it works in all cases.Refs #3817 #3822