New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rotation support for non default display #4698

Closed

eiyooooo wants to merge 1 commit into Genymobile:dev from eiyooooo:feature/rotation

Contributor

eiyooooo commented Feb 23, 2024

Here added new methods for rotation of external displays in android.view.IWindowManager


          Add rotation support for non default display

d9b56d9

rom1v pushed a commit that referenced this pull request


          Add rotation support for non-default display

63dd071

Use new methods introduced by this commit:
<https://android.googlesource.com/platform/frameworks/base/+/90c9005e687aa0f63f1ac391adc1e8878ab31759%5E%21/>

PR #4698 <#4698>

Signed-off-by: Romain Vimont <rom@rom1v.com>

Collaborator

rom1v commented Feb 26, 2024

Thank you, LGTM 👍

I made minor changes: 63dd071

Could you please review and confirm this is ok for you?

Contributor Author

eiyooooo commented Feb 26, 2024

I made minor changes: 63dd071

Could you please review and confirm this is ok for you?

That's totally ok for me. Thanks for this amazing project.❤️

Collaborator

rom1v commented Feb 26, 2024 •

edited

Merged ~~63dd071~~ d894e27 into dev.

rom1v closed this

rom1v pushed a commit that referenced this pull request


          Add rotation support for non-default display

d894e27

Use new methods introduced by this commit:
<https://android.googlesource.com/platform/frameworks/base/+/90c9005e687aa0f63f1ac391adc1e8878ab31759%5E%21/>

PR #4698 <#4698>

Signed-off-by: Romain Vimont <rom@rom1v.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment