Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Cmd instead of Ctrl on macOS #676

Merged
merged 1 commit into from
Aug 3, 2019
Merged

Use Cmd instead of Ctrl on macOS #676

merged 1 commit into from
Aug 3, 2019

Conversation

rom1v
Copy link
Collaborator

@rom1v rom1v commented Jul 31, 2019

Use Cmd instead of Ctrl for all shortcuts on macOS.

Fixes #642


Mac users, please confirm that it works as expected 馃槈

cc @npes87184 @carstenhag @zhuxianfeng13 @AoDevBlue @numbermaniac

@rom1v rom1v mentioned this pull request Jul 31, 2019
@carstenhag
Copy link

carstenhag commented Aug 1, 2019

Hey, I've compiled and tried it out just now.

Cmd+M does not work as excepted, because Cmd+M is a mac (global?) shortcut to minimize the window.

The other shortcuts work fine. One thing though, which I guess is unrelated: I have no way to middle-click on a Magic Mouse. On the Macbook touchpad it's possible but really difficult depending on the touchpad settings. It would be good to provide an alternative shortcut for that.+

Sadly, Cmd+H stands for hide this window on the Mac, so we can't/shouldn't use it.

@rom1v
Copy link
Collaborator Author

rom1v commented Aug 1, 2019

@carstenhag Thank you very much for your tests and feedback.

So I updated this PR to keep Ctrl for Ctrl+h and Ctrl+m.

I have no way to middle-click on a Magic Mouse. On the Macbook touchpad it's possible but really difficult depending on the touchpad settings. It would be good to provide an alternative shortcut for that.

What would you suggest? I will probably use Ctrl+click or Shift+click for "pinch to zoom". Maybe Ctrl+Right-click or something like that?

@carstenhag
Copy link

Yeah, Cmd+Click seems good to me.

@rom1v
Copy link
Collaborator Author

rom1v commented Aug 4, 2019

Cmd+click for HOME or pinch-to-zoom (not implemented yet)?

@carstenhag
Copy link

Not really sure what you mean by pinch-to-zoom :)

Cmd for Home, Shift for that, seems good to me. We can still test it later.

@rom1v
Copy link
Collaborator Author

rom1v commented Aug 4, 2019

Not really sure what you mean by pinch-to-zoom :)

#24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants