Add support for CTRL+S to send hardware "shake" to device

[atrich]

When developing for React Native, shaking the physical Android device is how you pull up the React Native debug menu, which is a very common task.

This catches the CTRL+S key combination and maps it to the "shake" keycode (keycode 82, AKEYCODE_MENU).

[rom1v]

Hi,

Thank you for the PR. 👍 Adding this shortcut is a good idea.

"Shake" seems very specific to React Native, so it seems to me that MENU is a better name. Could you rename it, please?

(Please edit your commits to apply the changes, using git rebase: this whole PR could fit in only 1 commit, since it is a single technical/functional change.)

Also, could you change its target from master to dev, please? The idea is that the "home page" of the project should always contain valid information for the current (latest) release.

[rom1v]

For consistency:

click on MENU

[rom1v]

There are also shortcut descriptions for scrcpy --help in main.c. Could you also add one for MENU below APP_SWITCH like here?

[rom1v]

@atrich Do you want me to apply the requested changes for you?

[atrich]

@rom1v Sorry for the delay - I believe I have responded to the feedback, rebased, and am requesting a merge into dev now. Let me know if there's other feedback!

[rom1v]

Thank you 👍

I also swapped the shortcuts to avoid confusion: 88ee6bc

[ihwf]

Thank you 👍

I also swapped the shortcuts to avoid confusion: 88ee6bc

This can not work on my MacOS , short press ctrl+M trigger APP_SWITCH, the same as command+S, and long press ctrl+M well trigger shake device , I don't know why must be long press?

[rom1v]

short press ctrl+M trigger APP_SWITCH, the same as command+S, and long press ctrl+M well trigger shake device

Actually, Ctrl+m is for MENU, and Cmd+s is for APP_SWITCH:

scrcpy/app/src/main.c

Lines 157 to 161 in 8ec077c

	" " CTRL_OR_CMD "+s\n"
	" click on APP_SWITCH\n"
	"\n"
	" Ctrl+m\n"
	" click on MENU\n"

scrcpy/app/src/input_manager.c

Lines 310 to 321 in 8ec077c

	case SDLK_s:
	if (control && cmd && !shift && !repeat) {
	action_app_switch(controller, action);
	}
	return;
	case SDLK_m:
	// Ctrl+m on all platform, since Cmd+m is already captured by
	// the system on macOS to minimize the window
	if (control && ctrl && !meta && !shift && !repeat) {
	action_menu(controller, action);
	}
	return;

I don't really know what "shake device" is in practice, but for example in the VLC app, Ctrl+m opens the menu and Ctrl+s (Cmd+s on macOS) correctly move into the "app switch" mode.

Note that you can inject these events manually via adb:

adb shell input keyevent APP_SWITCH
adb shell input keyevent MENU

[ihwf]

short press ctrl+M trigger APP_SWITCH, the same as command+S, and long press ctrl+M well trigger shake device

Actually, Ctrl+m is for MENU, and Cmd+s is for APP_SWITCH:

scrcpy/app/src/main.c

Lines 157 to 161 in 8ec077c

	" " CTRL_OR_CMD "+s\n"
	" click on APP_SWITCH\n"
	"\n"
	" Ctrl+m\n"
	" click on MENU\n"

scrcpy/app/src/input_manager.c

Lines 310 to 321 in 8ec077c

	case SDLK_s:
	if (control && cmd && !shift && !repeat) {
	action_app_switch(controller, action);
	}
	return;
	case SDLK_m:
	// Ctrl+m on all platform, since Cmd+m is already captured by
	// the system on macOS to minimize the window
	if (control && ctrl && !meta && !shift && !repeat) {
	action_menu(controller, action);
	}
	return;

I don't know what "shake device" is, but for example in the VLC app, Ctrl+m opens the menu and Ctrl+s (Cmd+s on macOS) correctly move into the "app switch" mode.

Note that you can inject these events manually via adb:

adb shell input keyevent APP_SWITCH
adb shell input keyevent MENU

I mean short press Ctrl +m handle "app switch" on my MacOS, it's wrong, I want to opens the menu, and when I long press Ctrl +m , it can opens the menu, I don't know why long press is right

[rom1v]

I mean short press Ctrl +m handle "app switch" on my MacOS

I don't know how it's even possible, looking at the source code. 😕

What is the result of scrcpy -v?

[ihwf]

I don't know how it's even possible, looking at the source code. 😕

What is the result of scrcpy -v?

scrcpy 1.11

dependencies:
- SDL 2.0.10
- libavcodec 58.54.100
- libavformat 58.29.100
- libavutil 56.31.100

It's a strange problem, maybe it's not a general problem, have you test on MacOS ?

[r4dixx]

This can not work on my MacOS , short press ctrl+M trigger APP_SWITCH, the same as command+S, and long press ctrl+M well trigger shake device , I don't know why must be long press?

@ihwf Haven't tested this feature, but ctrl + m and cmd + s work as expected here. Maybe you have some keyboard conflicts linked to custom keybindings and/or locale settings? Just a supposition.

scrcpy 1.11

dependencies:
- SDL 2.0.10
- libavcodec 58.54.100
- libavformat 58.29.100
- libavutil 56.31.100

Darwin parprpmc008675a 18.7.0 Darwin Kernel Version 18.7.0: Sat Oct 12 00:02:19 PDT 2019; root:xnu-4903.278.12~1/RELEASE_X86_64 x86_64

ProductName: Mac OS X
ProductVersion: 10.14.6
BuildVersion: 18G1012