Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo and link #927

Closed
wants to merge 1 commit into from
Closed

fix typo and link #927

wants to merge 1 commit into from

Conversation

Ddudduu
Copy link
Contributor

@Ddudduu Ddudduu commented Nov 15, 2019

I fixed a typo as an annotation of server.c and links of command.c , checkstyle.xml, gradle-wrapper.properties. Please check :)

app/src/sys/win/command.c Show resolved Hide resolved
app/src/server.c Show resolved Hide resolved
config/checkstyle/checkstyle.xml Show resolved Hide resolved
@@ -99,7 +99,7 @@ page at http://checkstyle.sourceforge.net/config.html -->
<module name="WhitespaceAround" />

<!-- Modifier Checks -->
<!-- See http://checkstyle.sf.net/config_modifiers.html -->
<!-- See http://checkstyle.sf.net/config_modifier.html -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-5.5.1-all.zip
distributionUrl=https://services.gradle.org/distributions/gradle-5.5.1-all.zip
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is auto-generated, so : must probably be kept escaped.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it doesn’t work when I escape :
Then, is it better not to fix this one ?-?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it doesn’t work when I escape

What's your error message?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it’s not error, it’ s not connected right away.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is "not connected"?

Copy link
Contributor Author

@Ddudduu Ddudduu Nov 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Umm I mean, when I type escaping : , it is just searched on the web. But, when I type https://services.gradle.org/distributions/gradle-5.5.1-all.zip , it is downloaded directly.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is parsed and interpreted by gradle, some characters are escaped probably to work with same separators accepted by the format, but in the end they are unescaped to retrieve the content.

Copy link
Contributor Author

@Ddudduu Ddudduu Nov 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then, is it better to use original link?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

rom1v pushed a commit that referenced this pull request Nov 18, 2019
PR <#927>

Signed-off-by: Romain Vimont <rom@rom1v.com>
@rom1v
Copy link
Collaborator

rom1v commented Nov 18, 2019

Merged as 7aed5d5.

@rom1v rom1v closed this Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants