Add some test

[npes87184]

• test_strquote
• test_buffer_util

[rom1v]

👍 Cool, more tests! 🎉

I will review this soon.

[rom1v]

Great. 👍

If you're ok with my proposed diff, I can merge them directly 😉

[rom1v]

I suggest to replace this by a single strcmp() call:

diff --git a/app/tests/test_strutil.c b/app/tests/test_strutil.c
index f4afabd..1489b1b 100644
--- a/app/tests/test_strutil.c
+++ b/app/tests/test_strutil.c
@@ -131,11 +131,8 @@ static void test_strquote(void) {
     const char *s = "abcde";
     char *out = strquote(s);
 
-    // add '"' in the begin and the end, also check out is null terminated
-    assert((strlen(s) + 2) == strlen(out));
-
-    // check only add '"' in the begin and the end
-    assert(!strncmp(s, out + 1, strlen(s)));
+    // add '"' at the beginning and the end
+    assert(!strcmp("\"abcde\"", out));
 
     SDL_free(out);
 }

It catches more possible errors (it asserts the expected output, not only some of its characteristics).

[rom1v]

👍

[rom1v]

👍

(nitpick: I would just change the code style a bit)

diff --git a/app/tests/test_buffer_util.c b/app/tests/test_buffer_util.c
index 3d2cf3b..ba3f9f0 100644
--- a/app/tests/test_buffer_util.c
+++ b/app/tests/test_buffer_util.c
@@ -41,29 +41,26 @@ static void test_buffer_write64be(void) {
 }
 
 static void test_buffer_read16be(void) {
-    uint16_t val;
     uint8_t buf[2] = {0xAB, 0xCD};
 
-    val = buffer_read16be(buf);
+    uint16_t val = buffer_read16be(buf);
 
     assert(val == 0xABCD);
 }
 
 static void test_buffer_read32be(void) {
-    uint32_t val;
     uint8_t buf[4] = {0xAB, 0xCD, 0x12, 0x34};
 
-    val = buffer_read32be(buf);
+    uint32_t val = buffer_read32be(buf);
 
     assert(val == 0xABCD1234);
 }
 
 static void test_buffer_read64be(void) {
-    uint64_t val;
     uint8_t buf[8] = {0xAB, 0xCD, 0x12, 0x34,
                       0x56, 0x78, 0x90, 0xEF};
 
-    val = buffer_read64be(buf);
+    uint64_t val = buffer_read64be(buf);
 
     assert(val == 0xABCD1234567890EF);
 }

[npes87184]

LGTM!

[rom1v]

Merged on dev:

• 5eeaed0
• b2bf25c
• fbc86a6