Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: space filler content #42

Merged
merged 1 commit into from Oct 10, 2022
Merged

fix: space filler content #42

merged 1 commit into from Oct 10, 2022

Conversation

tnrdd
Copy link
Collaborator

@tnrdd tnrdd commented Oct 10, 2022

Description

Give space between the placeholder box and the below text when there is not yet content linked to a parcel.

fixes #41

Checklist:

  • My commit message follows the Conventional Commits specification
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested my code
  • My changes generate no new warnings
  • My PR is rebased off the most recent main or appropriate feature branch
  • My PR is opened against the main or appropriate feature branch

Alert Reviewers

@codynhat @gravenp

gravenp
gravenp approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@gravenp gravenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks, @tnrdd.

@codynhat you can merge as appropriate.

@codynhat codynhat merged commit 559b417 into Geo-Web-Project:main Oct 10, 2022
@tnrdd tnrdd deleted the fix/empty-filler branch October 26, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codynhat codynhat codynhat approved these changes

@gravenp gravenp gravenp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spacing is off on the screen when a parcel exists but doesn't have content
3 participants
@tnrdd @codynhat @gravenp