Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Flexible number of rounds per game #125

Closed
wlanowski opened this issue Mar 2, 2021 · 4 comments · Fixed by #511
Closed

[FEAT] Flexible number of rounds per game #125

wlanowski opened this issue Mar 2, 2021 · 4 comments · Fixed by #511
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest
Projects
RoadMap

Comments

@wlanowski
Copy link
Contributor

https://discord.com/channels/758443244387303435/792739542058532865/816424488471494676
@wlanowski wlanowski added the enhancement New feature or request label Mar 2, 2021
@BilelJegham BilelJegham added this to Needs triage in RoadMap Mar 3, 2021
@BilelJegham
Copy link
Member

I see issues with his request.
With more rounds, games will not have the same maximum score (5000). History sorting will become complex.

@BilelJegham BilelJegham added the question Further information is requested label Mar 5, 2021
@BilelJegham BilelJegham moved this from Needs triage to Questions in RoadMap Mar 5, 2021
@wlanowski
Copy link
Contributor Author

I see issues with his request.
With more rounds, games will not have the same maximum score (5000). History sorting will become complex.

Sad story... For me it would be more interesting to have flexible number of rounds, than to have a history with max score... :/

@BilelJegham BilelJegham removed the question Further information is requested label Mar 7, 2021
@BilelJegham
Copy link
Member

If you think, it should be appreciated by players. You can implement it.

It's not complicated.
You have nbRound variable in StreetView.vue

https://github.com/GeoGuess/Geoguess/blob/dc36c681e42eec76e5ee880546a2fea6b8603f79/src/pages/StreetView.vue#L186

For the game settings (menu,...), you can follow work made it #118

@BilelJegham BilelJegham mentioned this issue Jul 30, 2021
Open
@BilelJegham BilelJegham added the good first issue Good for newcomers label Aug 26, 2021
@BurAndBY
Copy link

I'm not very good at programming, but i found this website

BilelJegham added a commit that referenced this issue Jul 31, 2022
@BilelJegham
feat: #125 Flexible number of rounds per game
fdf27be
@BilelJegham BilelJegham mentioned this issue Jul 31, 2022
Merged
3 tasks
BilelJegham added a commit that referenced this issue Aug 1, 2022
@BilelJegham
feat: #125 Flexible number of rounds per game (#511)
8a967ac 
* feat: #125 Flexible number of rounds per game

* mock csv export

* fix: dev mode e2e
RoadMap automation moved this from Questions to Closed Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest
Projects
RoadMap
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: #125 Flexible number of rounds per game GeoGuess/GeoGuess
3 participants
@BilelJegham @wlanowski @BurAndBY