Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #125 Flexible number of rounds per game #511

Merged
merged 4 commits into from
Aug 1, 2022

Conversation

BilelJegham
Copy link
Member

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description

Close #125

How Has This Been Tested?

Select a number of round and play.

Screenshots (if appropriate):

image

@codecov
Copy link

codecov bot commented Jul 31, 2022

Codecov Report

Merging #511 (5c78b51) into master (d15b9f4) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #511      +/-   ##
==========================================
+ Coverage   51.34%   51.47%   +0.13%     
==========================================
  Files          52       52              
  Lines         742      744       +2     
  Branches      205      206       +1     
==========================================
+ Hits          381      383       +2     
  Misses        329      329              
  Partials       32       32              
Impacted Files Coverage Δ
src/components/DialogSummary.vue 100.00% <ø> (ø)
src/components/Maps.vue 100.00% <ø> (ø)
...rc/components/dialogroom/card/CardRoomSettings.vue 100.00% <ø> (ø)
src/components/history/HistoryTable.vue 100.00% <ø> (ø)
src/pages/StreetView.vue 100.00% <ø> (ø)
src/store/modules/home.store.js 64.51% <100.00%> (ø)
src/store/modules/settings.store.js 24.84% <100.00%> (+0.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d15b9f4...5c78b51. Read the comment docs.

@BilelJegham BilelJegham enabled auto-merge (squash) August 1, 2022 19:04
@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.4% 4.4% Duplication

@BilelJegham BilelJegham merged commit 8a967ac into master Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Flexible number of rounds per game
1 participant