Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/reword maps home container #370

Merged
merged 4 commits into from
Jan 7, 2022

Conversation

BilelJegham
Copy link
Member

@BilelJegham BilelJegham commented Jan 5, 2022

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description

Closes #187 #348

How Has This Been Tested?

On the home page, tape a name, description or author in the search bar.

Screenshots (if appropriate):

screenshot

@BilelJegham BilelJegham linked an issue Jan 5, 2022 that may be closed by this pull request
@sonarcloud
Copy link

sonarcloud bot commented Jan 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #370 (c6600de) into master (72c1fa5) will increase coverage by 0.58%.
The diff coverage is 75.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #370      +/-   ##
==========================================
+ Coverage   42.10%   42.69%   +0.58%     
==========================================
  Files          43       44       +1     
  Lines        1375     1396      +21     
  Branches      263      270       +7     
==========================================
+ Hits          579      596      +17     
- Misses        771      775       +4     
  Partials       25       25              
Impacted Files Coverage Δ
src/components/home/SearchBox.vue 50.00% <ø> (ø)
src/components/home/card/HomeCard.vue 70.00% <ø> (ø)
src/components/home/card/HomeCardDialog.vue 84.21% <ø> (ø)
src/store/homeStore.js 64.34% <0.00%> (-1.14%) ⬇️
src/App.vue 80.00% <25.00%> (ø)
src/components/home/MapsContainer.vue 89.47% <89.47%> (ø)
src/models/GeoMap.js 92.59% <100.00%> (+0.92%) ⬆️
src/pages/Home.vue 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72c1fa5...c6600de. Read the comment docs.

@BilelJegham BilelJegham marked this pull request as ready for review January 6, 2022 22:20
@BilelJegham BilelJegham merged commit 025376a into master Jan 7, 2022
@BilelJegham BilelJegham deleted the feature/reword-maps-home-container branch January 10, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant