Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chaparral Physics M64Vx2 - add response #1780

Closed
wants to merge 7 commits into from

Conversation

CBurton90
Copy link
Contributor

@CBurton90 CBurton90 commented Jul 12, 2023

From:

http://service.iris.edu/irisws/nrl/1/combine?instconfig=sensor_Chaparral_64Vx2_LP50_HF200_SG0.0275_STairPressure&format=stationxml

Related to deployment of new infrasound sensor for the GeoNet infrasound network.
This will replace aging sensors currently deployed (a mixture of absolute barometers (Setras) and low cost infrasound (InfraBSU)).
Following an internal evaluation the Chaparral M64Vx2 was selected as the most capable infrasound sensor for volcanic monitoring purposes within the GeoNet network in terms of frequency ranges and sensitivity.

rumachan
rumachan previously approved these changes Jul 12, 2023
Copy link
Contributor

@rumachan rumachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with that. Not that familiar with response xml files, but is just copied from the online resource. Compared and match. The other two files look good. Am assuming the serial number, etc are correct.

@ozym
Copy link
Contributor

ozym commented Jul 16, 2023

Looks pretty good, just a couple of things. We should remove the resourceId entry, this will be overwritten. We also may have a different protocol on the numbering of poles and zeros (i.e. start from 0 or start from 1).

elidana
elidana previously approved these changes Jul 16, 2023
Copy link
Contributor

@elidana elidana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! great we can use the NRL for this one :)

@CBurton90 CBurton90 dismissed stale reviews from rumachan and elidana via 3669081 July 17, 2023 20:37
@CBurton90
Copy link
Contributor Author

Looks pretty good, just a couple of things. We should remove the resourceId entry, this will be overwritten. We also may have a different protocol on the numbering of poles and zeros (i.e. start from 0 or start from 1).

@ozym Resource ID removed.

@CBurton90 CBurton90 requested a review from a team as a code owner October 31, 2023 21:23
@CBurton90
Copy link
Contributor Author

@ozym Do you mind having a glance at this? From memory it was all in order to be merged a wee while back, I've just tidied up some conflicts.

It is still failing one test above but unsure if that matters?

@CBurton90
Copy link
Contributor Author

Closing, using NRL xml copy directly instead:

#2132

@CBurton90 CBurton90 closed this Jul 10, 2024
@CBurton90 CBurton90 deleted the Chaparral_M64Vx2 branch July 10, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants