-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update code and tests post a linting check. #508
Conversation
Looks good. But TravisCI has problem in testing? |
Thanks @junghao just waiting on getting the code valid first before adding to travis. That will be the next step after all the code passes muster. Kicked travis to re-run the checks and it seems to have come back. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@ozym hope you don't mind, I've fixed the |
@danieldooley no problems, will need to be reviewed / ticked again. |
golangci-lint run -E gosec
Spotted one error related to reuse of a variable, but mostly error handling in tests and deadcode.
@danieldooley @junghao could you have a look through at some point. The only outstanding warning is about the last few lines of tools/sit/main.go (error handling in the "verbose" part).